consider it considered 😅

28 replies
-
@DavidDarnes @zachleat If it’s a public repo with mostly TypeScript then I don’t see nothing wrong with it, aside from wording maybe. At least it’s not blocking.
@elwinvaneede @zachleat I believe this is on Eleventy which has no TypeScript 😬
@DavidDarnes @elwinvaneede no no, it’s another repo I don’t even commit to. Just saw a PR with this comment and enjoyed the passive wording. I think the bot is fine
-
-
@zachleat why is it doing that? The hell?
@nachtfunke I think it is a repo specific add-on
@zachleat I see! I thought GitHub is out there shaming people into using typescript.
I was already sharpening my pitchforks!
@nachtfunke haha no no put those pitchforks away
@zachleat … for now
😈
@zachleat Which cursed GH action is this?!
@jaredwhite I think it’s a custom thing built on top of https://github.com/tj-actions/changed-files
@zachleat this would be reasonable in codebase that is already mostly TypeScript, but is it the case on the screenshot?
@brawaru yeah—you’re right. The repo is almost certainly TypeScript.
@zachleat the more I use TypeScript the less I wanna use TypeScript (I fully understand Svelte's decision to use JSDoc instead)
@fantinel a very good compromise 👍🏻
-
@nicknisi this one was Nick Nisi bait 😅
@zachleat consider increasing your maintenance burden
@brianleroux “we will pay you $1 now if you pay us $1000 later” DEAL—wait
@zachleat nice stable package you have there have you considered introducing a build step and dependency known for shipping breaking changes on semver minor/patch?
@brianleroux how dare you bring next.js into this
@zachleat the next version always fixes the last version but you need to suffer an apple style keynote with nft badge to find out how