27 replies

1. Private reply Mastodon 7 min later
2. uncenter Mastodon 35 min later

   @zachleat @eleventy @antfu sweet! some other observations:

   - `var Promise = global.Promise;` is this still needed? i think `Promise` is already available in the global scope by itself 🤔
   - why do `var EventEmitter = require('node:events').EventEmitter;` instead of `var { EventEmitter } = require('node:events');`? (why we are using `var` is another question entirely...)
   - i would think you can use node's `path.posix` methods instead of relying on the `slash` package? see https://nodejs.org/api/path.html#windows-vs-posix.

   1. Zach Leatherman Mastodon 36 min later

      @uncenter yeah! I did start with #1 but punted after I couldn’t get the repo’s linter to agree with it 😬 #2 and #3 would make good contributions! (this is a fork of an old dependency repo, fwiw, see https://github.com/11ty/eleventy/issues/3299)

      1. uncenter Mastodon 40 min later

         @zachleat > I couldn’t get the repo’s linter to agree with it

         probably because eslint is on version 2! 😅

         1. Zach Leatherman Mastodon 41 min later

            @uncenter I didn’t upgrade the dev deps — that package will go away in the future: https://github.com/11ty/eleventy/issues/3360

            1. uncenter Mastodon 51 min later

               @zachleat yeah i saw that- when would you be willing to require node >= v22.3.0 for eleventy?

               1. Zach Leatherman Mastodon 52 min later

                  @uncenter Not sure! My only point there is that it isn’t worth doing a ton of maintenance on dev deps there (imo) or even code style on the plugin code too for that matter

3. David ⚔️ Soards Bluesky 5 hr later

   🤓👉👉

   1. Zach Leatherman Bluesky 17 hr later

      I… don’t know what this means 😅

4. James Bluesky 11 hr later

   This is the kind of analysis everyone should be doing 🥹

   1. Zach Leatherman Bluesky 17 hr later

      thanks James!

5. Zach Leatherman Bluesky 17 hr later

   This is the one: bsky.app/profile/11ty...

   With a special nod to this PR to GitHub user Jeffalo (not on bsky): github.com/11ty/elevent...

   1. ‮Jeff Eaton Bluesky 18 hr later

      Absolutely love this. One of my first really large node projects (coincidentally inspired by 11ty’s appproach to many things) accumulated an ugly dependency count during its initial exploratory alpha stage and paring that down is slow, ugly, but rewarding work.

      1. Zach Leatherman Bluesky 18 hr later

         Yeah!! I love these kinds of improvements — they make installs faster and you can feel a little bit of the maintenance burden lift which is always lovely

   2. Keith Duke Bluesky 18 hr later

      No rifraf takes on new meaning 😀

      1. Zach Leatherman Bluesky 18 hr later

         we’ll take rif or raf but will absolutely not tolerate them together

   3. James Bluesky 18 hr later

      This is a common one we've been cleaning up in @e18e.dev too. For anyone interested, if you need a cli, use premove. Otherwise, use fs.rm

      1. James Bluesky 18 hr later

         You can probably switch to tinyglobby, yaml (slightly bigger but maintained, more correct), and a few others too 👀

         1. Zach Leatherman Bluesky 18 hr later

            Thank you very much! I’ve added those recs to our issue tracker:

            github.com/11ty/elevent...
            github.com/11ty/elevent...

            1. James Bluesky 18 hr later

               I sent this thread to the community too and they picked out a few other things. Would you be happy for them to open issues? Or one umbrella issue to track all of the suggestions until they're accepted?

               1. James Bluesky 18 hr later

                  We will probably add an issue to the e18e issue tracker too to keep track of these contribs

                  1. Zach Leatherman Bluesky 19 hr later

                     just a side question: is there a CLI or package.json linter for github.com/es-tooling/m... ?

                     1. James Bluesky 19 hr later

                        This lint plugin uses the manifests from the replacements repo to report usages

                        1. Zach Leatherman Bluesky 19 hr later

                           tyvm!

               2. Zach Leatherman Bluesky 18 hr later

                  Oh wow that’d be amazing — an umbrella issue might be the easiest so I can triage the easiest! Thank you!

   4. Zach Leatherman Bluesky 18 hr later

      I’ve realized that I’ve linked to the issue and not the PR and am very embarrassed — what a gaffe, here is the PR: github.com/11ty/recursi...

6. Zach Leatherman Mastodon 18 hr later

   This is the one: https://fosstodon.org/@eleventy/114110182403525096

   With a special nod to GitHub user Jeffalo! (not on Mastodon)